Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flipperzero::furi::kernel module #180

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add flipperzero::furi::kernel module #180

merged 1 commit into from
Oct 22, 2024

Conversation

dcoles
Copy link
Collaborator

@dcoles dcoles commented Oct 21, 2024

This module exposes most of the furi_kernel_* APIs.

Centralizing these lets us remove a number of unsafe calls peppered across the codebase and allows things like providing optimized versions.

crates/flipperzero/src/furi/kernel.rs Outdated Show resolved Hide resolved
crates/flipperzero/src/furi/kernel.rs Outdated Show resolved Hide resolved
@dcoles dcoles force-pushed the furi-kernel branch 2 times, most recently from 228c5b7 to 46baae2 Compare October 22, 2024 02:10
@dcoles dcoles requested a review from JarvisCraft October 22, 2024 02:27
Copy link
Contributor

@JarvisCraft JarvisCraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a few non-critical suggestions

crates/flipperzero/src/furi/kernel.rs Outdated Show resolved Hide resolved
crates/flipperzero/src/furi/kernel.rs Show resolved Hide resolved
This module exposes most of the `furi_kernel_*` APIs.

Centralizing these lets us remove a number of `unsafe` calls peppered
across the codebase and allows things like providing optimized versions.
@JarvisCraft JarvisCraft added this to the v0.13.0 milestone Oct 22, 2024
@dcoles dcoles merged commit e0e4a50 into main Oct 22, 2024
9 checks passed
@dcoles dcoles deleted the furi-kernel branch October 22, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants